WIP: Use flexbox for Login #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpith
force-pushed
the
master
branch
4 times, most recently
from
b43c008 to
1b13157
Compare
arpith
force-pushed
the
master
branch
3 times, most recently
from
125bb50 to
58832e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The login page currently uses a bunch of hacks for layout. This pull requests rewrites it using css flexbox. The main goal is to have it work on mobile safari.
Currently, this branch implements two versions: the one below works on safari but is not aligned on chrome. The one above (in yellow and red) is aligned on chrome but does not wrap on safari the way the lower layout does.