Use the ruby_package when specified #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes code generation to prefer the ruby_package option when set in a proto file rather than trying to infer the name based on the protobuf package name. We have a case where we use an acronym (DMS for Dead Man's Snitch) in our packages and they would be generated at `Dms` instead of `DMS` which we overcome in other code specifying the ruby_package.
Contributor
Author
|
@arthurnn Sorry for the ping but any chance you could take a look at this at some point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes code generation to prefer the ruby_package option when set in a proto file rather than trying to infer the name based on the protobuf package name.
We have a case where we use an acronym (DMS for Dead Man's Snitch) in our packages and they would be generated at "Dms" instead of "DMS" which we overcome in other code by specifying the ruby_package.