Add support for per-request timeout #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aerendel
commented
Sep 20, 2023
| end | ||
| end | ||
|
|
||
| if req_opts && req_opts[:timeout] && req_opts[:timeout].is_a?(Integer) && req_opts[:timeout] > 0 |
Author
There was a problem hiding this comment.
I made a choice to ignore non positive Integer values because Faraday doesn't actually check this and fails rather hard with a NoMethod error if you don't pass in a number. If ignoring invalid values doesn't sound good, we could instead raise a ArgumentError here and make the request fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for specifying a per-rpc timeout rather than being forced to use a single timeout across the whole twirp client. This is something that my team is needing so we aren't required to create entire new clients just for specific RPCs that we want to allow longer timeouts for. Since Faraday supports this natively, it makes sense to expose it here.