Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1066 delay loading of context socket until it is actually used. #1068

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DominicWatson
Copy link

This allows running of custom logic before the connection that might effect the connection options. i.e. see #1065 and related PR: #1067.

This has been tested locally on a simple scenario and does not appear to adversely effect running of socketio tests. The connection will be made eventually when needed.

… used.

This allows running of custom logic before the connection that might effect the connection options
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants