dockerfile: Run npm link #1395
Open
dockerfile: Run npm link #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes artilleryio#1394. The currently built container image works fine if you want to invoke artillery through a single docker command. But if you want to run multiple artillery commands in the same container instance, or if you want to use Artillery's container image as a base layer, then you ran into issues such artilleryio#1394. The issue us that the executable in the path is named `run` instead of `artillery`. To address this while maintain compatibility for any users depending on the existing executable we can run an `npm install` which will setup artillery as if it had been installed globally.
nzapo
force-pushed
the
dockerfile-npm-link
branch
from
21b5866 to
5209e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently built container image works fine if you want to
invoke artillery through a single docker command. But if you want to run
multiple artillery commands in the same container instance, or if you
want to use Artillery's container image as a base layer, then you ran
into issues such #1394.
The issue us that the executable in the path is named
runinstead ofartillery. To address this while maintain compatibility for any usersdepending on the existing executable we can run an
npm installwhichwill setup artillery as if it had been installed globally.
Fixes #1394.