Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect invalid node version #1423

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

magentaqin
Copy link

#1411 detect invalid node version and show friendly error messages

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ magentaqin
❌ juanig1


juanig1 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@juanig1 juanig1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the delay!
Thanks for the PR!!
Left a couple of comments to discuss with you if that's alright 💪

@juanig1 juanig1 self-assigned this Jun 30, 2022
@juanig1
Copy link
Contributor

juanig1 commented Jul 19, 2022

@magentaqin hey qm!
Just added a minor commit that takes into account the previous comments, so we can get this merged.
Thanks again for your contribution!

juanig1
juanig1 previously approved these changes Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants