Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leakage + upgrade packages with vulnerabilities + support for running requests one time before start of test #482

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DinaYakovlev
Copy link

We had a memory leakage because of data that is being saved that seemed to be unnecessary.
(The _entries that is being saved in the aggregate object)
We deleted the data and also upgraded the 'lodash' and 'debug' packages because of known vulnerabilities issues:
https://nodesecurity.io/advisories/534
https://nodesecurity.io/advisories/577

@hassy
Copy link
Member

hassy commented Jun 5, 2018

Thanks for the PR @DY6229! I'll try to review & respond asap.

@enudler
Copy link

enudler commented Jun 24, 2018

Very useful fix

@DinaYakovlev
Copy link
Author

Added another commit.
This commit has the option to make requests before test start to run. the artillery json now can have another section called ‘before’, which has a single flow (like in a scenario) that will run once before the test.
also now this fork is rebased to this project with the last few merges.

@DinaYakovlev DinaYakovlev changed the title Memory leakage + upgrade packages with vulnerabilities Memory leakage + upgrade packages with vulnerabilities + support for running requests one time before start of test Jul 5, 2018
…vulnerabilities 3. remove entries from aggregate data
@Kosta-Github
Copy link

@DY6229 is the before section only run once globally or run once for each individual virtual user? I would be in need for the latter, e.g., for a user login flow to generate an auth token used for that user for all subsequent requests...

@hassy any chance to get that in?

@hassy
Copy link
Member

hassy commented Aug 17, 2018

@Kosta-Github you can use a function step in your scenario definition to set up some state for each new virtual user: https://artillery.io/docs/http-reference/#function-steps-in-a-flow

@DY6229 There are 3 separate changes in this PR - is there any chance you could split those out (+ investigate why tests are failing)? The new before hook especially would be extremely useful. :)

@NivLipetz
Copy link
Contributor

@hassy, @Kosta-Github the before section is in PR here: #612

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Dina Yakovlev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants