-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leakage + upgrade packages with vulnerabilities + support for running requests one time before start of test #482
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR @DY6229! I'll try to review & respond asap. |
Very useful fix |
Added another commit. |
…vulnerabilities 3. remove entries from aggregate data
@DY6229 is the @hassy any chance to get that in? |
@Kosta-Github you can use a @DY6229 There are 3 separate changes in this PR - is there any chance you could split those out (+ investigate why tests are failing)? The new |
@hassy, @Kosta-Github the before section is in PR here: #612 |
Dina Yakovlev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
We had a memory leakage because of data that is being saved that seemed to be unnecessary.
(The _entries that is being saved in the aggregate object)
We deleted the data and also upgraded the 'lodash' and 'debug' packages because of known vulnerabilities issues:
https://nodesecurity.io/advisories/534
https://nodesecurity.io/advisories/577