Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response codes and errors graph correction in report #743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

onionka
Copy link

@onionka onionka commented Sep 12, 2019

Response Codes and Errors graphs are being interpolated wrongly because there were missing 0 values. This PR is adding zeros to the places with missing values in these graphs. I had to fix it in the report manually, so I thought it would be nice to contribute to here.

This is what it looked like before fix:
Screenshot from 2019-09-12 08-38-28

@hassy
Copy link
Member

hassy commented Sep 21, 2019

Thanks @Cmiroslaf! It's very difficult to see where the change is exactly though because the entire file seems to have been reformatted. Would you mind updating the PR keeping the original whitespace so that the change can be seen?

@onionka
Copy link
Author

onionka commented Oct 31, 2019

Sorry for the late response. Ok, I removed it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants