Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary switch support to socketio engine #855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jfkz
Copy link

@jfkz jfkz commented Jul 6, 2020

There is a feature in socket.io that can transfer binary data between server and client sockets:
https://socket.io/docs/server-api/#Flag-%E2%80%98binary%E2%80%99-1

I write simple solution to support this but cant create tests for it (request help).

Please, review and comment if there is something wrong.

@jfkz jfkz force-pushed the add-binary-to-socket-io branch from 802f923 to 3913a27 Compare July 6, 2020 16:27
@jfkz jfkz force-pushed the add-binary-to-socket-io branch from 3913a27 to d353722 Compare July 6, 2020 16:30
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants