Improve hybrid NLTE performance #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeshingles
force-pushed
the
hybridnlteperf
branch
2 times, most recently
from
c72f9f3 to
1d034d4
Compare
lukeshingles
changed the title
lukeshingles
force-pushed
the
hybridnlteperf
branch
2 times, most recently
from
f8ee86e to
9c287a5
Compare
lukeshingles
force-pushed
the
hybridnlteperf
branch
from
9c287a5 to
6dd0b78
Compare
lukeshingles
force-pushed
the
hybridnlteperf
branch
from
6dd0b78 to
c1cbdcb
Compare
lukeshingles
force-pushed
the
hybridnlteperf
branch
from
11b6bcc to
0a2bb61
Compare
lukeshingles
force-pushed
the
hybridnlteperf
branch
2 times, most recently
from
6d1b6b0 to
3b97811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Total ion photoionisation rate was being recalculated at every iteration of the T_e and nne for ions of elements without NLTE levels, which caused major slowdowns (4x runtime for simple one-zone). The total ion photoionisation rate coefficient for ions of elements without NLTE levels is now calculated only once per T_e change.