Refactor boundary checks and remove last_cross #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeshingles
force-pushed
the
rpktrefactor
branch
5 times, most recently
from
87f99d9 to
66f188c
Compare
lukeshingles
force-pushed
the
rpktrefactor
branch
2 times, most recently
from
ea0bc9b to
c5e3616
Compare
lukeshingles
force-pushed
the
rpktrefactor
branch
2 times, most recently
from
69351a9 to
6ad2a8e
Compare
lukeshingles
force-pushed
the
rpktrefactor
branch
from
6ad2a8e to
10a58c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W7 2e9 pkt 960 cores on JUWELS Skylake nodes is 9% faster. sim2010 classic mode is ~1-2% faster.
The "last_cross" direction is not needed since the packet direction contains enough information to avoid multiply crossing the same boundary.