Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper / Cheat Sheet vs Code inconsistency #268

Open
willat343 opened this issue May 21, 2023 · 2 comments
Open

Paper / Cheat Sheet vs Code inconsistency #268

willat343 opened this issue May 21, 2023 · 2 comments

Comments

@willat343
Copy link
Contributor

The paper and the cheat sheet has the lie algebra of the R^n group as R^n.

However in the code the lie algebra of the R^n group is an (n+1)x(n+1) matrix, and the hat() operator of RnTangentBase creates this matrix with the vector coefficients in the top right corner.

I'm wondering which is correct and why there is a difference?

@joansola
Copy link
Collaborator

joansola commented Jun 3, 2023

See #109 for context and some reasoning around this. You will need to scroll down quite a lot, until around this #109 (comment).

See also #114 for the final decision

@willat343
Copy link
Contributor Author

Ok so it seems like the final decision was to make the lie algebra x^ = x.hat() = [0 x ; 0 0]?

This makes sense to me (admittedly with much less knowledge in this area than yourself and artivis) with the lie bracket equal to zero: [x^, y^] = x^ * y^ - y^ * x^ = 0. If x^ == x (a vector instead of a matrix) then I don't see how this makes sense.

Therefore can I suggest that the cheat sheet be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants