Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing not equal != operator #316

Closed
willat343 opened this issue Dec 20, 2024 · 3 comments
Closed

Missing not equal != operator #316

willat343 opened this issue Dec 20, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@willat343
Copy link
Contributor

The equality operator == is implemented in lie_group_base.h but the != operator is not. Would you be able to add this?
@willat343 willat343 changed the title Missing not qual != operator Missing not equal != operator Dec 20, 2024
@artivis
Copy link
Owner

artivis commented Jan 6, 2025

Hi @willat343 ,
How do you feel about giving it a go yourself? If you're not up for that, I'll look at it look over the weekend 👍 .

@artivis artivis added enhancement New feature or request good first issue Good for newcomers labels Jan 6, 2025
@MarshallVielmetti MarshallVielmetti mentioned this issue Jan 24, 2025
Merged
artivis added a commit that referenced this issue Feb 8, 2025
@artivis
Merge pull request #318 from MarshallVielmetti/devel
9a45168 
Added NEQ to lie_group_base (Issue #316)
@artivis
Copy link
Owner

artivis commented Feb 8, 2025

This is solved by #318 . Closing.

@artivis artivis closed this as completed Feb 8, 2025
@willat343
Copy link
Contributor Author

Thanks. It was a small thing but just didn’t have time to get to it myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artivis @willat343