fix: properly pass missing env vars in Plugin.Update #1899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-rodriguez
force-pushed
the
fix/missing_env_vars
branch
from
8a9ae5a to
e782ebc
Compare
missingcharacter
added a commit
to missingcharacter/asdf-direnv
that referenced
this pull request
Feb 7, 2025
…and unsetting it in `env_teardown` until asdf-vm/asdf#1899 is merged
Stratus3D
reviewed
Feb 8, 2025
internal/plugins/plugins.go
Outdated
| @@ -255,6 +255,9 @@ func (p Plugin) Update(conf config.Config, ref string, out, errout io.Writer) (s | |||
| } | |||
|
|
|||
| env := map[string]string{ | |||
| "HOME": os.Getenv("HOME"), | |||
| "ASDF_DIR": os.Getenv("ASDF_DIR"), | |||
There was a problem hiding this comment.
ASDF_DIR isn't something that is used in asdf 0.16.0+. Are there still plugins relying on this?
There was a problem hiding this comment.
Are there still plugins relying on this?
There was a problem hiding this comment.
Is there a reason why we shouldn't propagate all env variables of the current process by default here (similar to #1958 )?
There was a problem hiding this comment.
ping @Stratus3D thank you!
n-rodriguez
force-pushed
the
fix/missing_env_vars
branch
from
e782ebc to
74d22f9
Compare
n-rodriguez
force-pushed
the
fix/missing_env_vars
branch
from
74d22f9 to
6b5a9fb
Compare
Stratus3D
reviewed
Feb 19, 2025
n-rodriguez
force-pushed
the
fix/missing_env_vars
branch
from
6b5a9fb to
69b55ca
Compare
n-rodriguez
force-pushed
the
fix/missing_env_vars
branch
from
69b55ca to
71e8cbb
Compare
|
Closed in favor of #1982 |
|
Replaced by #1982 |
|
@Stratus3D Closed in favor of #1982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Properly pass missing env vars in Plugin.Update
Fixes:
Thank you!