-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve zsh completion suggestions #1933
base: master
Are you sure you want to change the base?
Conversation
internal/completions/asdf.zsh
Outdated
#compdef asdf | ||
#description tool to manage versions of multiple runtimes | ||
|
||
# Initialize local variables for ZSH completion context | ||
local curcontext="$curcontext" state state_descr line subcmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see curcontext
used anywhere. Can it be removed?
Same comment about state_descr
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Valgard ! I'm going to test these changes out today and merge if they work as expected.
By the way, do you happen to know if there are any automated tools for validation completion code? Manual testing has been pretty time consuming for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I type asdf plugin list
and hit tab and it converts the command to asdf plugin postgres
. Unclear why this occurs.
Hey, I'm not an expert, but as far as I know, there are only two test frameworks that support shell completion tests (both supports ZSH):
|
21f528a
to
cab4f7b
Compare
I'm really sorry, but I can't reproduce this behaviour. |
# Conflicts: # internal/completions/asdf.zsh
improve zsh completion suggestions with flags, git refs, versions, etc.