Bundle profiling instrumentation into a shared DLL #158
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| name: CI | ||
|
|
||
| # Run on every push and on pull requests targeting any branch. | ||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Build GpProfDll + run DUnit tests (Win32) | ||
| runs-on: windows-latest | ||
|
|
||
| env: | ||
| # Set the BDS repository variable to the RAD Studio installation root, | ||
| # e.g. C:\Program Files (x86)\Embarcadero\Studio\23.0 (Delphi 12 Athens) | ||
| # C:\Program Files (x86)\Embarcadero\Studio\22.0 (Delphi 11 Alexandria) | ||
| # On a self-hosted runner the variable is usually already set in the system | ||
| # environment; override it here as needed via Settings → Variables → Actions. | ||
| BDS: ${{ vars.BDS }} | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| # ----------------------------------------------------------------------- | ||
| # Locate the Delphi compiler. We try the BDS repository variable first, | ||
| # then fall back to the most common installation paths for Delphi 12/11. | ||
| # ----------------------------------------------------------------------- | ||
| - name: Locate Delphi installation | ||
| id: delphi | ||
| shell: pwsh | ||
| run: | | ||
| $bds = $env:BDS | ||
| if (-not $bds) { | ||
| $candidates = @( | ||
| 'C:\Program Files (x86)\Embarcadero\Studio\23.0', | ||
| 'C:\Program Files (x86)\Embarcadero\Studio\22.0', | ||
| 'C:\Program Files (x86)\Embarcadero\Studio\21.0', | ||
| 'C:\Program Files (x86)\Embarcadero\Studio\20.0' | ||
| ) | ||
| foreach ($p in $candidates) { | ||
| if (Test-Path "$p\bin\DCC32.exe") { $bds = $p; break } | ||
| } | ||
| } | ||
| if (-not $bds -or -not (Test-Path "$bds\bin\DCC32.exe")) { | ||
| Write-Error @" | ||
| Delphi DCC32.exe not found. | ||
| Set the BDS Actions repository variable to your RAD Studio installation directory, | ||
| e.g. C:\Program Files (x86)\Embarcadero\Studio\23.0 | ||
| or use a self-hosted runner that already has Delphi on PATH. | ||
| "@ | ||
| exit 1 | ||
| } | ||
| Write-Host "Delphi found at: $bds" | ||
| # Export for subsequent steps | ||
| "BDS=$bds" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
|
|
||
| - name: Add MSBuild to PATH | ||
| uses: microsoft/setup-msbuild@v2 | ||
|
|
||
| # ----------------------------------------------------------------------- | ||
| # Build the profiling instrumentation DLL (Win32, Release). | ||
| # ----------------------------------------------------------------------- | ||
| - name: Build GpProfDll (Win32 · Release) | ||
| shell: pwsh | ||
| run: | | ||
| msbuild source\gpprof.dll\GpProfDll.dproj ` | ||
| /t:Build ` | ||
| /p:Config=Release /p:Platform=Win32 ` | ||
| /v:minimal /nologo | ||
|
|
||
| # ----------------------------------------------------------------------- | ||
| # Build the DUnit test console application (Win32, Release). | ||
| # DCC_ExeOutput is set to "." in the project, so the exe lands in | ||
| # source\gpprof.dll.tests\ alongside the stub GpProfDllTests.GPI file. | ||
| # ----------------------------------------------------------------------- | ||
| - name: Build GpProfDllTests (Win32 · Release) | ||
| shell: pwsh | ||
| run: | | ||
| msbuild source\gpprof.dll.tests\GpProfDllTests.dproj ` | ||
| /t:Build ` | ||
| /p:Config=Release /p:Platform=Win32 ` | ||
| /v:minimal /nologo | ||
|
|
||
| # ----------------------------------------------------------------------- | ||
| # Run the DUnit tests. | ||
| # TextTestRunner.RunRegisteredTests sets ExitCode to | ||
| # FailureCount + ErrorCount; exit 0 means all tests passed. | ||
| # ----------------------------------------------------------------------- | ||
| - name: Run DUnit tests | ||
| shell: pwsh | ||
| run: | | ||
| & .\source\gpprof.dll.tests\GpProfDllTests.exe | ||
| if ($LASTEXITCODE -ne 0) { | ||
| Write-Error "DUnit tests failed (exit code $LASTEXITCODE)" | ||
| exit $LASTEXITCODE | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ BIN/gpprof.drc | |
| BIN/gpprof.exe | ||
| BIN/gpprof.map | ||
| *.~dsk | ||
| source/GpProfDllTestApp/Win32/Debug/*.* | ||
|
Owner
There was a problem hiding this comment. Add a Action for the ci Build calling the Tests
Contributor
Author
There was a problem hiding this comment. Done in 35c0f87.
To enable the workflow on the GitHub-hosted runner, set a repository variable
Owner
There was a problem hiding this comment. Add a Action for the ci Build calling the Tests |
||
| *.identcache | ||
| *.rsmres | ||
| *.res | ||
|
|
@@ -19,11 +19,19 @@ bin64/*.map | |
| BIN/*.map | ||
| *.dproj.local | ||
| **/__history | ||
| /source/GpProf.UI/__recovery/__recovery.ini | ||
| /source/GpProf.UI/__recovery/gppMain.dfm | ||
| /source/GpProf.UI/__recovery/gppMain.pas | ||
| /source/GpProf.UI/ui/VirtualTree.Tools/__recovery/__recovery.ini | ||
| /source/GpProf.UI/ui/VirtualTree.Tools/__recovery/virtualTree.tools.statistics.pas | ||
| *.dsk | ||
| *.bk2 | ||
| /gpprof_2017* | ||
| source/gpprof.dll.tests/*.exe | ||
| source/gpprof.dll.tests/*.map | ||
| source/gpprof.dll.tests/Win32/ | ||
| source/gpprof.dll.tests/Win64/ | ||
| source/GpProfDllTestApp/Win32/ | ||
| source/GpProfDllTestApp/Win64/ | ||
| /source/gpprof.dll/Win32/** | ||
| /source/gpprof.dll/Win64/** | ||
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the main UI application to
source/GpProf.UI
Leave the .bat where they are. Update the script to point to the proper location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 84ac6fe. All UI application files (
gpprof.dpr/dproj,HISTORY/OPTIONS/baggage/help.inc,gpprof_Icon.ico,gpParser.MeasurePoint.pas,icons/,model/,ui/) have been moved tosource/GpProf.UI/.source/build.batstays in place and has been updated to referenceGpProf.UI\gpprof.dpr,GpProf.UI\baggage.rc, andGpProf.UI\gpprof.rc. All relative paths ingpprof.dprojhave been updated from..\to..\..\.