Open
Conversation
NutharaNR
force-pushed
the
fix/rename-flowId-to-flowExecId
branch
from
9c26c20 to
19dd39f
Compare
NutharaNR
force-pushed
the
fix/rename-flowId-to-flowExecId
branch
4 times, most recently
from
2aa8f21 to
19dd39f
Compare
NutharaNR
force-pushed
the
fix/rename-flowId-to-flowExecId
branch
from
b5f75b0 to
2eb2da1
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| '@asgardeo/javascript': patch | |||
Contributor
There was a problem hiding this comment.
I think these has to be a minor release.
cc: @brionmario
| currentFlowId, | ||
| flowIdStorageKey: FLOW_ID_STORAGE_KEY, | ||
| currentExecutionId, | ||
| executionIdStorageKey: FLOW_ID_STORAGE_KEY, |
Contributor
There was a problem hiding this comment.
Will it makes sense to change FLOW_ID_STORAGE_KEY as well (both key and value)?
@brionmario WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rename
flowIdin flow execution in thunder toflowExecId.Related Issues
Related PRs
Checklist
Security checks