Fix filter evaluation for subscriptions #388
Merged
+35
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass record, context, and resource to Ash.Expr.eval when evaluating filters. Update tests to create real Actor records (use UUIDs) and reference actor IDs from created records. Replace actor_id attribute with a belongs_to(:actor) relation and change the read policy to use relates_to_actor_via/1 so subscription authorization behaves correctly.
zachdaniel
approved these changes
Dec 6, 2025
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass record, context, and resource to Ash.Expr.eval when evaluating filters. Update tests to create real Actor records (use UUIDs) and reference actor IDs from created records. Replace actor_id attribute with a belongs_to(:actor) relation and change the read policy to use relates_to_actor_via/1 so subscription authorization behaves correctly.
Contributor checklist
Leave anything that you believe does not apply unchecked.