Disable downloadimg spec #16
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that add_development_dependency does NOT allow the major version difference
Fix typo
Install the latest bundler
mrkn
reviewed
Feb 25, 2019
| @@ -24,7 +24,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency 'uuidtools', '~> 2.1' | |||
| spec.add_dependency 'launchy', '~> 2.4' | |||
|
|
|||
| spec.add_development_dependency 'bundler', '~> 1.12' | |||
| spec.add_development_dependency 'bundler', '~> 2.0.0' | |||
There was a problem hiding this comment.
I think Bundler 2 has not been recommended yet.
mrkn
reviewed
Feb 25, 2019
| # expect(generated_image).not_to include('errors') | ||
| # end | ||
| # end | ||
| # end |
There was a problem hiding this comment.
How about using pending instead of comment out?
mrkn
reviewed
Feb 25, 2019
| sudo: false | ||
| cache: bundler | ||
| #sudo: false | ||
| #cache: bundler |
There was a problem hiding this comment.
Why don't you delete these lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downloadimgspec is disabled in this pull-req.It is hard to keep working it in
.travis.yml.And this makes difficult to update plotly.js.
(And it is more important in practice than to keep working the spec.)
I checked it worked well in this
downloadimgspec disabled version(with)
Please allow me to merge this pull-req to master.