Use Mazur-bound small-multiple torsion check in rank search#6
Open
asiryan wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
5040*Pscalar multiplication which can be very expensive and may cause the example to hang for curves with positive rank.RankLowerBoundFromSearchfor typical inputs.Description
torsionKiller = 5040approach inRankLowerBoundFromSearchwith a direct call to a new helperIsTorsionByMazurBound.IsTorsionByMazurBound(EllipticCurvePoint)which tests whether a point is torsion by checking multiplesk*Pfor1..16and returns true when a multiple is the point at infinity.sources/EllipticCurveQ.Analysis.csand only affect the torsion filtering step of the rational-point search used for rank lower bounds.Testing
dotnet run --project /workspace/EllipticCurves/examples; automated run failed becausedotnetis not available in the environment.Codex Task