Skip to content

fix: breaking changes introduced in nbformat 3#111

Merged
aslowwriter merged 1 commit into
mainfrom
chore/update-deps
May 6, 2026
Merged

fix: breaking changes introduced in nbformat 3#111
aslowwriter merged 1 commit into
mainfrom
chore/update-deps

Conversation

@aslowwriter
Copy link
Copy Markdown
Owner

@aslowwriter aslowwriter commented May 6, 2026

Explanation

Nbformat 3.0 and jupyter-protocol added some new enum variants, which is technically a braking change but really not a big deal.

General Checklist

  • Updated tests or added new tests (if applicable)
  • Branch is up to date with main
  • Tests & lints hooks pass
  • Updated documentation (if applicable)
  • History of branch is cleaned up

@aslowwriter aslowwriter changed the title fix: fix breaking changes introduced in nbformat 3 fix: breaking changes introduced in nbformat 3 May 6, 2026
@aslowwriter aslowwriter force-pushed the chore/update-deps branch 3 times, most recently from a07e4f9 to 7528141 Compare May 6, 2026 12:52
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.4%. Comparing base (822c263) to head (1dc6638).

Files with missing lines Patch % Lines
src/parsing/python/jupyter.rs 20.0% 4 Missing ⚠️
src/render/jupyter.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/cli/mod.rs 89.4% <ø> (ø)
src/parsing/sphinx/types.rs 94.7% <ø> (ø)
src/render/jupyter.rs 66.6% <0.0%> (ø)
src/parsing/python/jupyter.rs 65.5% <20.0%> (-8.6%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aslowwriter aslowwriter force-pushed the chore/update-deps branch from 7528141 to 1dc6638 Compare May 6, 2026 12:58
@aslowwriter aslowwriter merged commit 03bfc4b into main May 6, 2026
7 checks passed
@aslowwriter aslowwriter deleted the chore/update-deps branch May 6, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant