Skip to content

Commit

Permalink
refactor: normalize pnpm lockfile data in parser (#1735)
Browse files Browse the repository at this point in the history
  • Loading branch information
jbedard authored May 21, 2024
1 parent cc17b7d commit aa106ad
Show file tree
Hide file tree
Showing 17 changed files with 621 additions and 250 deletions.
2 changes: 2 additions & 0 deletions e2e/pnpm_lockfiles/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ TODO:
- npm: references: `@aspect-test/a2": "npm:@aspect-test/a"`

No :node_modules/\* targets are generated for aliases to npm packages.

Note: _sometimes_ fails to install with pnpm9
1 change: 1 addition & 0 deletions e2e/pnpm_lockfiles/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"uvu": "0.5.6",
"@scoped/a": "workspace:*",
"@scoped/b": "link:../projects/b",
"@scoped/c": "file:../projects/c",
"@scoped/d": "../projects/d"
},
"devDependencies": {
Expand Down
5 changes: 2 additions & 3 deletions e2e/pnpm_lockfiles/lockfile-test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,8 @@ def lockfile_test(name = None):
# Direct deps from custom registry
# ":.aspect_rules_js/node_modules/@[email protected]+@[email protected]",

# TODO: differs across lockfile versions
# Direct deps with peers differ across lockfile versions
# ":.aspect_rules_js/node_modules/@[email protected]_@[email protected]",
# Direct deps with peers
":.aspect_rules_js/node_modules/@[email protected]_at_aspect-test_c_2.0.2",
],
)

Expand Down
9 changes: 9 additions & 0 deletions e2e/pnpm_lockfiles/v54/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions e2e/pnpm_lockfiles/v54/snapshots/defs.bzl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions e2e/pnpm_lockfiles/v60/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions e2e/pnpm_lockfiles/v60/snapshots/defs.bzl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions e2e/pnpm_lockfiles/v61/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions e2e/pnpm_lockfiles/v61/snapshots/defs.bzl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions e2e/pnpm_lockfiles/v90/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions e2e/pnpm_lockfiles/v90/snapshots/defs.bzl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit aa106ad

Please sign in to comment.