Repository navigation
Inline normalize_lexically to support stable Rust - #382
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
normalize_lexicallypath method is nightly-only. The current nightly version also returnsResultand errors on leading.., which made%include ../foo.gsfrom a root file panic viaunwrap, andgoboscript build ../project/main.gspanic on startup.What changed
src/misc.rs: skip., resolve..against the previous component, keep leading..in relative paths, drop..at an absolute root, return `." when nothing remains.#![feature(normalize_lexically)]gate, so the crate builds on stable.cargo fmt(nightly rustfmt options).Behavior notes
..includes no longer panic; they resolve as written.%include ./fooand%include foonow produce the same dedupe key, so the same file can no longer be included twice.Include.pathserialized to wasm/LSP clients changes from./foo.gstofoo.gsfor relative invocations.