fix(release): validate custom version input and include all changelog entries#3
Merged
fix(release): validate custom version input and include all changelog entries#3
Conversation
… entries Signed-off-by: assagman <ahmetsercansagman@gmail.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
This PR addresses two issues from a previous review: adds validation for the custom_version workflow input to ensure it follows strict semver format, and removes the head -10 truncation from the changelog generation to include all non-conventional commits.
Changes:
- Add semver validation to
custom_versioninput (stripsvprefix, validates X.Y.Z format, fails with clear error on invalid input) - Remove
head -10truncation from OTHERS changelog generation to include all non-conventional commits
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses two valid review comments from PR #2:
custom_versioninput — ensures strict semver format (X.Y.Zorv1.2.3), stripsvprefix, and fails fast with clear error on invalid inputhead -10truncation — changelog "Changed" section now includes all non-conventional commits instead of silently truncatingChanges
release-pr.ymlinputs.custom_versionrelease-pr.ymlhead -10from OTHERS changelog generationTesting
abc) — should failv2.0.0) — should succeed