Skip to content

Check member policy in extension order - #328

Merged
woodruffw merged 1 commit into
ww/logical-test-cleanupfrom
ww/check-member-policy
Nov 10, 2026
Merged

woodruffw merged 1 commit into
ww/logical-test-cleanupfrom
ww/check-member-policy

Conversation

@woodruffw

@woodruffw woodruffw commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Match on the member's extension format once. For PAX, check each positioned extension in archive order. For a forbidden GNU member, report the earliest long-name or long-link header, falling back to the member header when it has neither.

The metadata integration tests exercise two cases where order matters. A forbidden global PAX header precedes a forbidden local vendor record, and a GNU long-link header precedes a long-name header.

Ran cargo test --locked -p tar-codec --test members --test metadata.

@woodruffw
woodruffw added this pull request to stack #325 November 10, 2026 22:09
@woodruffw woodruffw changed the title ww/check member policy Check member policy in extension order Nov 10, 2026
@codspeed

codspeed Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 28 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing ww/check-member-policy (5bb5d5d) with ww/logical-test-cleanup (590ae80)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@woodruffw
woodruffw marked this pull request as ready for review November 10, 2026 22:15
@woodruffw
woodruffw force-pushed the ww/check-member-policy branch from 06baf39 to 1a4bc64 Compare November 10, 2026 22:22
@woodruffw
woodruffw force-pushed the ww/check-member-policy branch from 1a4bc64 to 5bb5d5d Compare November 10, 2026 22:30
@woodruffw
woodruffw merged commit 6eed2c2 into main Nov 10, 2026
14 of 17 checks passed
@woodruffw
woodruffw deleted the ww/check-member-policy branch November 10, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant