Repository navigation
Test global PAX updates through the logical reader - #329
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
woodruffw
marked this pull request as ready for review
November 10, 2026 22:17
woodruffw
force-pushed
the
ww/pax-update-test
branch
from
November 10, 2026 22:22
cf8be25 to
3143761
Compare
woodruffw
force-pushed
the
ww/pax-update-test
branch
from
November 10, 2026 22:30
3143761 to
80ee808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fold the global PAX update check into the logical reader test. Retain the first physical extension across a second global header that replaces the same keyword. The next member sees the replacement, and the retained extension still exposes the original value.
This removes a unit test that compared the address of the global-state slot across an update.
Ran
cargo test --locked -p tar-framing --lib global.