Skip to content

Test global PAX updates through the logical reader - #329

Merged
woodruffw merged 1 commit into
ww/check-member-policyfrom
ww/pax-update-test
Nov 10, 2026
Merged

woodruffw merged 1 commit into
ww/check-member-policyfrom
ww/pax-update-test

Conversation

@woodruffw

@woodruffw woodruffw commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Fold the global PAX update check into the logical reader test. Retain the first physical extension across a second global header that replaces the same keyword. The next member sees the replacement, and the retained extension still exposes the original value.

This removes a unit test that compared the address of the global-state slot across an update.

Ran cargo test --locked -p tar-framing --lib global.

@woodruffw
woodruffw added this pull request to stack #325 November 10, 2026 22:09
@woodruffw woodruffw changed the title ww/pax update test Test global PAX updates through the logical reader Nov 10, 2026
@codspeed

codspeed Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 28 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing ww/pax-update-test (80ee808) with ww/check-member-policy (5bb5d5d)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@woodruffw
woodruffw marked this pull request as ready for review November 10, 2026 22:17
@woodruffw
woodruffw merged commit 672cd7c into main Nov 10, 2026
14 of 17 checks passed
@woodruffw
woodruffw deleted the ww/pax-update-test branch November 10, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant