Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the v from version, to match ruff #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CoderJoshDK
Copy link
Contributor

Since version 0.5, ruff has dropped the v in its version. This mirrors that.

As mentioned and done in astral-sh/uv-pre-commit#5, ruff no longer has v in its version. This PR removes it. This is an in between commit while I wait for approval of a bigger restructure.

This also undos #92. As mentioned there, the reason the link was wrong, was because of the de-sync between version semantics.

Important

After merging, manually create a new tag and version.

@CoderJoshDK CoderJoshDK reopened this Jul 18, 2024
@CoderJoshDK
Copy link
Contributor Author

Because I know this will take a while to get to, just let me know when (or if) you are going to merge this. Because it also requires the change of the README to work properly. (remove the V from the ever-changing version, so the regex picks it up). Well ... I could make the regex pick up the v "optionally" and drop it. But that feels wrong.

@dhruvmanila dhruvmanila requested a review from zanieb July 22, 2024 05:28
@GabDug
Copy link

GabDug commented Aug 5, 2024

Hey 👋!

I wanted to add my 2 cents on this change. Several projects that synchronise pre-commit hooks and locked versions use a mapping between PyPI packages and pre-commit repositories, with a default "database" and user-configured mappings. These mappings often include information on whether the tags for each repository include the v prefix. Introducing a different tag format for the same repository could create compatibility issues for these tools, as they behave in a more basic way than pre-commit autoupdate that was mentioned in #92.

While it is possible for tools to implement special handling for the specific cases of ruff and uv, I would advise against making this change or introducing both tag formats. Such changes could introduce unnecessary complexity and potential for errors, or require a manual user-configuration depending on the version used.

For reference, here are some examples of tools that would be affected:

Have a great day!

@MichaReiser
Copy link
Member

@GabDug thanks for the added perspective on this.

My concern with removing the v prefix is that this is also likely to break existing tools and workflows. For example, wouldn't it require your tool to use the mapping with the v prefix up to version 0.5, then without the v prefix up to 0.5.6, and then go back to the mapping with the v prefix for versions > 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants