[ty] Correct enum alias detection and scalar constructors#26345
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.47%. The percentage of expected errors that received a diagnostic held steady at 89.19%. The number of fully passing files held steady at 95/134. |
Memory usage reportMemory usage unchanged ✅ |
|
99d868a to
dae9f0d
Compare
65f063a to
1599879
Compare
1599879 to
6ce7e33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enum member metadata currently uses full
Typevalues when identifying duplicate-value aliases. Literal metadata such as promotability is therefore treated as part of runtime identity, so equivalent values can incorrectly remain separate canonical members.We also only look for value-transforming
__new__implementations on enum classes. Python'sEnumTypecan instead use a user-defined__new__from a non-enum data-type mixin to construct the member's scalar payload. Ignoring that constructor can leave.valueas the declared literal, skip constructor argument validation, and mark a runtime-reachable equality branch as unreachable.This keys alias detection by runtime literal kind and payload, and includes user-defined data-type mixin constructors in enum value-construction metadata:
Enum aliases now resolve to the same canonical member even when their inferred literal types differ only in metadata, while transformed scalar-mixin values remain conservative unless we can model the constructor.