[ty] Use never-change durability for one-shot checks#26359
Draft
MichaReiser wants to merge 1 commit into
Draft
Conversation
MichaReiser
force-pushed
the
micha/one-shot-never-change-inputs
branch
from
a189517 to
5b1b3af
Compare
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.47%. The percentage of expected errors that received a diagnostic held steady at 89.19%. The number of fully passing files held steady at 95/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
|
Merging this PR will improve performance by 5.36%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | sympy |
76.1 s | 71 s | +7.19% |
| ⚡ | Memory | hydra-zen |
53 MB | 49.7 MB | +6.75% |
| ⚡ | Memory | anyio |
67.7 MB | 63.6 MB | +6.37% |
| ⚡ | WallTime | pydantic |
8.4 s | 8 s | +5.67% |
| ⚡ | Simulation | hydra-zen |
1.5 s | 1.4 s | +5.05% |
| ⚡ | Simulation | anyio |
1.3 s | 1.3 s | +5.02% |
| ⚡ | Memory | attrs |
31.1 MB | 29.7 MB | +4.88% |
| ⚡ | WallTime | altair |
1.8 s | 1.7 s | +4.39% |
| ⚡ | WallTime | freqtrade |
10.4 s | 10 s | +4.31% |
| ⚡ | Simulation | DateType |
257.9 ms | 247.9 ms | +4.01% |
Tip
Curious why this is faster? Use the CodSpeed MCP and ask your agent.
Comparing micha/one-shot-never-change-inputs (5b1b3af) with main (825509f)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
MichaReiser
added
performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Salsa's
NEVER_CHANGEdurability for program, project, and newly created file inputs during one-shotty checkruns. This avoids recording unnecessary dependencies while keeping fixes, watch mode, and the server incremental.Builds on #26353. Across the eight wall-time projects, the change reduced wall time by 6.2% geomean and peak RSS by 11.3% geomean.
Test Plan
Testing: Passed the ty CLI, ruff_db, and ty_project test suites, Clippy, and repository hooks.