Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send JMX metrics to prometheus #956

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

fjammes
Copy link
Contributor

@fjammes fjammes commented Feb 7, 2025

  • Add monitoring to all spark tasks
  • Add prometheus JMX exporter jar in Dockerfile:
    • Use latest release jmx_prometheus_javaagent-1.1.0.jar
  • Add support for monitoring in e2e test script
  • Bump ciux to v0.0.5-rc0
  • Add monitoring label to spark namespace
  • Install and configure prometheus in CI
  • Hack to try to solve kafka startup problem

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #931

What changes were proposed in this pull request?

Prometheus integration

How was this patch tested?

e2e test pass successfully

@fjammes fjammes linked an issue Feb 7, 2025 that may be closed by this pull request
- Add monitoring to all spark tasks
- Add prometheus JMX exporter jar in Dockerfile:
  * Use latest release jmx_prometheus_javaagent-1.1.0.jar
- Add support for monitoring in e2e test script
- Bump ciux to v0.0.5-rc0
- Add monitoring label to spark namespace
- Install and configure prometheus in CI
- Hack to try to solve kafka startup problem
@fjammes fjammes force-pushed the 931-improve-fink-broker-monitoring branch from 1f08e46 to 77c8a77 Compare February 7, 2025 15:13
@fjammes fjammes changed the title Send JMX metrics tow prometheus Send JMX metrics to prometheus Feb 7, 2025
Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link
Member

@JulienPeloton JulienPeloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me -- thanks for the monitoring capabilities!

@JulienPeloton JulienPeloton added monitoring k8s Kubernetes deployment labels Feb 12, 2025
@fjammes fjammes merged commit e27cd11 into master Feb 17, 2025
16 checks passed
@fjammes fjammes deleted the 931-improve-fink-broker-monitoring branch February 17, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes deployment monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve fink-broker monitoring
2 participants