-
-
Notifications
You must be signed in to change notification settings - Fork 2k
DOC: Clarify that parquet needs pandas #17976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Thanks @pllim. This also needs to be fixed at https://github.com/d-giles/astropy/blob/8c7593268512594921159000de7a9f885b398fa3/astropy/io/misc/parquet.py#L66-L67. And in the "nothing is ever easy" category, we probably want to include the standard optional-dependency handling. Somewhere around here we want: |
Co-authored-by: Tom Aldcroft <[email protected]>
|
Thanks, @taldcroft ! I added a commit to address your review and added you as co-author of that commit. |
taldcroft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This comment was marked as resolved.
This comment was marked as resolved.
|
Hmm. Probably not worth a manual backport. Changing milestone. p.s. Ugh did GitHub change squash merge logic? Co-author info is lost on squash merge, sorry about that. |
Description
This pull request is to fix #17972 . No need to run CI but please make sure RTD is green. Thanks!