Skip to content

Conversation

@pllim
Copy link
Member

@pllim pllim commented Apr 3, 2025

Description

This pull request is to fix #17972 . No need to run CI but please make sure RTD is green. Thanks!

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added the io.misc label Apr 3, 2025
@taldcroft
Copy link
Member

Thanks @pllim. This also needs to be fixed at https://github.com/d-giles/astropy/blob/8c7593268512594921159000de7a9f885b398fa3/astropy/io/misc/parquet.py#L66-L67.

And in the "nothing is ever easy" category, we probably want to include the standard optional-dependency handling. Somewhere around here we want:

    if not HAS_PANDAS:
        raise ModuleNotFoundError("pandas is required to read parquet files")

@pllim
Copy link
Member Author

pllim commented Apr 4, 2025

Thanks, @taldcroft ! I added a commit to address your review and added you as co-author of that commit.

Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@pllim pllim merged commit 2f687fc into astropy:main Apr 4, 2025
26 of 27 checks passed
@pllim pllim deleted the pandas-parquet branch April 4, 2025 21:14
@lumberbot-app

This comment was marked as resolved.

@pllim
Copy link
Member Author

pllim commented Apr 4, 2025

Hmm. Probably not worth a manual backport. Changing milestone.

p.s. Ugh did GitHub change squash merge logic? Co-author info is lost on squash merge, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can write but cannot read parquet table if pyarrow is installed but not pandas

2 participants