feat(s3): add unit tests and shorten ecs zip names#49
Merged
arielb1 merged 1 commit intoasync-profiler:mainfrom May 25, 2025
Merged
feat(s3): add unit tests and shorten ecs zip names#49arielb1 merged 1 commit intoasync-profiler:mainfrom
arielb1 merged 1 commit intoasync-profiler:mainfrom
Conversation
The ECS task name contains the cluster name, no need to have them both in the S3 .zip object name. this changes the names of the .zip files when using the agent for Fargate. The exact format of the names is not pinned down so this is not a semver break but be aware
jlizen
approved these changes
May 25, 2025
Collaborator
jlizen
left a comment
jlizen
left a comment
There was a problem hiding this comment.
Thanks for this!
Do you think it's worth an open issue to allow a custom prefix? And/or adding support for lambda metadata?
Contributor
Author
|
If someone wants a custom prefix or lambda metadata, they can open an issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ECS task name contains the cluster name, no need to have them both in the S3 .zip object name.
this changes the names of the .zip files when using the agent for Fargate. The exact format of the names is not pinned down so this is not a semver break but be aware
📬 Issue #, if available:
✍️ Description of changes:
🔏 By submitting this pull request