ci: sync lockfile in release PRs and skip AI disclosure on bot PRs#2124
Conversation
Append `npm install --package-lock-only --ignore-scripts` to the Changesets `version` command so the release PR regenerates package-lock.json alongside the bumped manifests, keeping `npm ci` consistent. Add a bot-actor guard to verify-ai-disclosure.yml so the AI-disclosure check does not run on machine-generated PRs (asyncapi-bot, dependabot). Refs: asyncapi#2123
|
What reviewer looks at during PR reviewThe following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.
|
📝 WalkthroughWalkthroughTwo GitHub Actions workflow fixes: the release workflow's ChangesCI Workflow Fixes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Regenerate the root lockfile so the workspace package versions and pinned internal dependency ranges match the manifests bumped by the last release, resolving the drift described in asyncapi#2123. Refs: asyncapi#2123
|
/rtm |
|



Description
Fixes two CI workflow issues described in #2123.
Problem 1 — Release PRs leave
package-lock.jsonstaleThe Changesets release PR runs only
changeset version, which rewritespackage.json/CHANGELOG.mdfiles but never runs an install, so the rootpackage-lock.jsondrifts out of sync with the bumped manifests (both the package's ownversionentry and the internal dependency pins in consumers). This makesnpm cifail and produces noisy lockfile diffs on later PRs.Fix: append
npm install --package-lock-only --ignore-scriptsto thechangesets/actionversioncommand inrelease-with-changesets.ymlso the release PR regenerates the lockfile alongside the manifests.--package-lock-onlyavoids a full reinstall (node_modules is already present from the earliernpm ci) and--ignore-scriptskeeps it side-effect-free.Problem 2 —
verify-ai-disclosure.ymlruns on bot PRsThe AI-disclosure check ran on every PR, including machine-generated ones (e.g. the Changesets release PR from
asyncapi-bot, anddependabot), adding noise on PRs no human authored.Fix: add a job-level actor guard that skips the check for known bot authors, consistent with how other PR-triggered workflows in this repo (e.g.
pr-review-checklist.yml) treat bots.Related issue(s)
Fixes #2123
Generated-by: Cursor Agent (Claude Opus 4.8)