Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After an actor is stopped, block continuations from running #2146

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

benbenwilde
Copy link
Contributor

Description

If there are any pending continuations after an actor is stopped, a Continuation system message will still be sent when its wait completes, and the Continuation will still run even though the actor is in a fully stopped state. This can result in some unexpected behavior including data corruption, since the actor could be running elsewhere at the same time (e.g. if it was moved to another node).

This PR adds checks before sending and handling a Continuation so this can no longer happen. A test was added to confirm the issue and the fix.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Sorry, something went wrong.

@rogeralsing rogeralsing merged commit 54eef66 into asynkron:dev Jan 23, 2025
18 checks passed
@rogeralsing
Copy link
Contributor

Very nice addition! many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants