Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for personio-py 1.0 #24

Draft
wants to merge 101 commits into
base: master
Choose a base branch
from
Draft

Refactoring for personio-py 1.0 #24

wants to merge 101 commits into from

Conversation

klamann
Copy link
Contributor

@klamann klamann commented Dec 23, 2021

refactoring of personio-py. Planned changes:

  • switch to poetry as build tool
  • simplify the data model with pydantic or a similar library
  • make use of Personio's new custom attributes API
  • code cleanup & better test coverage

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Patch coverage: 89.1% and project coverage change: -0.6% ⚠️

Comparison is base (b5ead78) 87.3% compared to head (0181d55) 86.7%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #24     +/-   ##
========================================
- Coverage    87.3%   86.7%   -0.6%     
========================================
  Files           7       8      +1     
  Lines         946     860     -86     
========================================
- Hits          826     746     -80     
+ Misses        120     114      -6     
Files Changed Coverage Δ
src/personio_py/g.py 77.7% <77.7%> (ø)
src/personio_py/client.py 80.7% <78.2%> (-1.1%) ⬇️
src/personio_py/util.py 83.3% <83.3%> (ø)
src/personio_py/models.py 91.9% <91.6%> (+1.4%) ⬆️
src/personio_py/__init__.py 100.0% <100.0%> (ø)
src/personio_py/errors.py 74.3% <100.0%> (ø)
src/personio_py/search.py 83.5% <100.0%> (+0.2%) ⬆️
src/personio_py/version.py 100.0% <100.0%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klamann klamann changed the title Feature/refactoring Refactoring for personio-py 1.0 Jan 7, 2022
klamann and others added 30 commits July 28, 2023 15:51
this won't work with current API responses though, we need to define a custom type
for pydantic 2.0, but this has become a bit more involved...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants