Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overall api usage #37

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

pietzschke
Copy link
Contributor

Checklist for your PR

  • please start with a draft PR and mark it as ready for review when you are confident that your implementation works as expected.
  • add a changelog entry in CHANGELOG.md with a link to this PR.
  • make sure that all tests pass and add new test functions if your code is not covered by existing tests. Please use mock tests when network requests are required.
  • let someone review & approve your code, make changes where necessary.

Hints

  • name your branches accordingly: use the prefixes bugfix/, feature/, or release/ and then a short title for your PR in kebab-case (lowercase words separated with dashes), e.g. feature/my-awesome-feature.
  • Please make sure that pre-commit hooks are enabled on your system to avoid common mistakes before you make a commit.
  • feel free to delete this template and replace it with your own description of the PR.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b5ead78) 87.31% compared to head (e7d0c96) 87.40%.
Report is 2 commits behind head on master.

❗ Current head e7d0c96 differs from pull request most recent head a5bff98. Consider uploading reports for the commit a5bff98 to get more accurate results

Files Patch % Lines
src/personio_py/mapping.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   87.31%   87.40%   +0.09%     
==========================================
  Files           7        7              
  Lines         946      961      +15     
==========================================
+ Hits          826      840      +14     
- Misses        120      121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant