Skip to content

fix: add explicit security options to OAuth cookies to prevent state mismatch errors #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: add explicit security options to OAuth cookies to prevent state mismatch errors #463

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26196ce
fix: add proper cookie options to OAuth state cookie
github-actions[bot] Oct 11, 2025
d18740b
fix: update cookie security settings for development environment
bisand Oct 11, 2025
da932a8
fix: enhance PKCE cookie security settings
bisand Oct 11, 2025
8f9134e
fix: standardize PKCE cookie settings and expiration time
bisand Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/runtime/server/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ import { subtle, getRandomValues } from 'uncrypto'
import type { OAuthProvider, OnError } from '#auth-utils'
import { createError } from '#imports'

// Determine if we are in development mode
const isDevelopment = process.env.NODE_ENV === 'development'

// OAuth cookie expiration time (10 minutes in seconds)
const OAUTH_COOKIE_MAX_AGE = 60 * 10

export function getOAuthRedirectURL(event: H3Event): string {
const requestURL = getRequestURL(event)

Expand Down Expand Up @@ -190,7 +196,13 @@ export async function handlePkceVerifier(event: H3Event) {

// Create new verifier
verifier = encodeBase64Url(getRandomBytes())
setCookie(event, 'nuxt-auth-pkce', verifier)
setCookie(event, 'nuxt-auth-pkce', verifier, {
httpOnly: true,
secure: !isDevelopment,
sameSite: 'lax',
maxAge: OAUTH_COOKIE_MAX_AGE,
path: '/',
})

// Get pkce
const encodedPkce = new TextEncoder().encode(verifier)
Expand All @@ -212,6 +224,12 @@ export async function handleState(event: H3Event) {
}

state = encodeBase64Url(getRandomBytes(8))
setCookie(event, 'nuxt-auth-state', state)
setCookie(event, 'nuxt-auth-state', state, {
httpOnly: true,
secure: !isDevelopment,
sameSite: 'lax',
maxAge: OAUTH_COOKIE_MAX_AGE,
path: '/',
})
return state
}
Loading