Update firebase_auth_platform_interface + Pigeon - #127
Merged
Conversation
|
This PR is neccesary to be compatible with latest firebase_auth, that sets firebase_auth_platform_interface: ^9.0.1 |
Contributor
Author
|
Seems it failed on the formatting, but I don't know how the formatter is configured in the pipeline. Mine has some custom options such as longer line length etc. and if I run dart format he wants to update 7 files (even untouched ones). So can this be merged regardless of the formatting? |
Owner
|
Don't worry about it, I'll fix it myself. Thanks for the fix! |
Merged
Owner
|
I just published your fix to https://pub.dev/packages/firebase_auth_mocks/changelog#0152. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix for upgrading the firebase_auth_platform_interface major version to 9.x and used the newly renamed internal objects. Tests are passing. @atn832