Skip to content

Various issue 819 fixes #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025
Merged

Various issue 819 fixes #841

merged 5 commits into from
Apr 22, 2025

Conversation

ianrrees
Copy link
Contributor

Summary

While investigating #819 I made a few documentation changes, added ability to tune the DPLL filters, and added a method to check the DFLLRDY status bit. Although the actual issue in 819 turned out to not be in our code, these might be useful additions.

Checklist

  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

@jbeaurivage
Copy link
Contributor

jbeaurivage commented Apr 16, 2025

Thank you for this. Did we reach a conclusion wrt the chicken-egg problem of having the DFLL defaulting to being on-demand, and therefore won't be ready unless there's a GCLK requesting it before it's turned on? Is it just a matter of documenting that behavior, or there still more work to be done?

I think an alternative that has been suggested is to force the user to explicitly choose whether they want on_demand to be on or off. That would be a good place to document the implications of leaving it on.

Otherwise I'm pretty happy with this!

@ianrrees
Copy link
Contributor Author

I think that the on_demand thing isn't too big of a footgun; it only shows up if a check is added that the PLL is running, which in most cases probably isn't necessary. We could put it in an example code along with a comment about why it is where it is.

Which reminds me, I think I noticed some example code in clock v2 that wanted an update... Will aim to look at that soon so let's not merge this quite yet.

@jbeaurivage
Copy link
Contributor

The "code that wanted an update" was most likely in the ADC PR (#814) if that's of any help!

@jbeaurivage
Copy link
Contributor

@ianrrees were there any discussion points still open about this PR? Any more work to be done?

@ianrrees
Copy link
Contributor Author

I've rebased to the current master, and updated that example code to use Fugit - think this should be good to go, thanks!

@jbeaurivage jbeaurivage merged commit 7669bc8 into atsamd-rs:master Apr 22, 2025
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants