fixup! refactor(core): Add fake navigation to primitives for code sha…

…ring
atscott · Feb 14, 2025 · 6550957 · 6550957
1 parent 5ce8c36
commit 6550957
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 15 deletions.
diff --git a/packages/common/testing/BUILD.bazel b/packages/common/testing/BUILD.bazel
@@ -10,7 +10,6 @@ ng_module(
     deps = [
         "//packages/common",
         "//packages/core",
-        "//packages/core/testing",
         "@npm//rxjs",
     ],
 )

diff --git a/packages/common/testing/src/navigation/fake_navigation.ts b/packages/common/testing/src/navigation/fake_navigation.ts
@@ -6,4 +6,4 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-export {ɵFakeNavigation as FakeNavigation} from '@angular/core/testing';
+export {ɵFakeNavigation as FakeNavigation} from '@angular/core';
diff --git a/packages/core/BUILD.bazel b/packages/core/BUILD.bazel
@@ -31,6 +31,7 @@ ng_module(
     deps = [
         "//packages:types",
         "//packages/core/primitives/dom-navigation",
+        "//packages/core/primitives/dom-navigation/testing",
         "//packages/core/primitives/event-dispatch",
         "//packages/core/primitives/signals",
         "//packages/core/src/compiler",

diff --git a/packages/core/primitives/dom-navigation/testing/BUILD.bazel b/packages/core/primitives/dom-navigation/testing/BUILD.bazel
@@ -2,9 +2,8 @@ load("//tools:defaults.bzl", "ts_library", "tsec_test")
 
 package(default_visibility = [
     "//packages:__pkg__",
-    "//packages/common:__subpackages__",
+    "//packages/core:__pkg__",
     "//packages/core/primitives/dom-navigation/testing:__subpackages__",
-    "//packages/core/testing:__subpackages__",
     "//tools/public_api_guard:__pkg__",
 ])
 

diff --git a/packages/core/src/core_private_export.ts b/packages/core/src/core_private_export.ts
@@ -21,6 +21,7 @@ export {
   type NavigationInterceptOptions as ɵNavigationInterceptOptions,
   type NavigationDestination as ɵNavigationDestination,
 } from '../primitives/dom-navigation';
+export {FakeNavigation as ɵFakeNavigation} from '../primitives/dom-navigation/testing';
 export {setAlternateWeakRefImpl as ɵsetAlternateWeakRefImpl} from '../primitives/signals';
 export {detectChangesInViewIfRequired as ɵdetectChangesInViewIfRequired} from './application/application_ref';
 export {INTERNAL_APPLICATION_ERROR_HANDLER as ɵINTERNAL_APPLICATION_ERROR_HANDLER} from './error_handler';

diff --git a/packages/core/testing/BUILD.bazel b/packages/core/testing/BUILD.bazel
@@ -13,7 +13,6 @@ ng_module(
         "//packages:types",
         "//packages/compiler",
         "//packages/core",
-        "//packages/core/primitives/dom-navigation/testing",
         "//packages/localize",
         "//packages/zone.js/lib:zone_d_ts",
         "@npm//@types/jasmine",

diff --git a/packages/core/testing/public_api.ts b/packages/core/testing/public_api.ts
@@ -14,6 +14,5 @@
  * Entry point for all public APIs of this package.
  */
 export * from './src/testing';
-export * from './src/testing_private_export';
 
 // This file only reexports content of the `src` folder. Keep it that way.
diff --git a/packages/core/testing/src/testing_private_export.ts b/packages/core/testing/src/testing_private_export.ts