Update zig libraries and remove vendored copies from this repo #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on MacOS: $ nix develop $ zig build
Fixes a build failure in curl version 5.2.3. Confirmed to build on Mac OS under `nix develop`.
update flake, which updates zig version to 0.14.0-dev.3091+42e48b83b and confirm that zig build completes successfully.
Previously, we used r-build-zig-0.5.0-no-deps in order to work around the zig build system bug that did not support http/https proxies. With the library restructuring taking place in r-build-zig's other dependencies, and with the upcoming 0.14.0 release which may require further library updates, it's easier to unvendor these dependencies for the time being.
std.mem.page_size has been removed.
For now, we don't wish to update R dependencies. This reverts commit 0f5246f.
and fix a dockerile warning
Nixpkgs 24.11 includes an update to libcurl which requires a corresponding update to RCurl on MacOS. However, we currently do not wish to update our R package dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removed the vendored zig libraries used as part of the zig build system to build rcloud, and replaces them with updated versions that make use of the zig package manager. This reduces a maintenance burden for library maintainers and reduces the size of this repository.
The zig package manager is included with the zig compiler, but it currently has a bug which causes it to fail if it is run behind an http proxy.
This pull request also updates R package dependencies to address a compile error with libcurl and the RCurl package.Downgrade nixpkgs to 24.05 to avoid new version of libcurl which is incompatible with our version of RCurl on MacOS.