fix: scope tmux history copy to active pane

[atxtechbro]

Git Statistics

• 1 file changed

Summary

• wrap tmux-copy-history in a helper that targets the active pane when inside tmux and last active pane otherwise
• keep capture options the same while preventing clipboard capture across other panes/sessions

Testing

• tmux_copy_history (manual) inside tmux

[amazon-q-developer]

⏳ Code review in progress. Analyzing for code quality issues and best practices. You can monitor the review status in the checks section at the bottom of this pull request. Detailed findings will be posted upon completion.

Using Amazon Q Developer for GitHub

Amazon Q Developer¹ is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation.

Slash Commands

Command	Description
/q <message>	Chat with the agent to ask questions or request revisions
/q review	Requests an Amazon Q powered code review
/q help	Displays usage information

Features

Agentic Chat
Enables interactive conversation with Amazon Q to ask questions about the pull request or request specific revisions. Use /q <message> in comment threads or the review body to engage with the agent directly.

Code Review
Analyzes pull requests for code quality, potential issues, and security concerns. Provides feedback and suggested fixes. Automatically triggered on new or reopened PRs (can be disabled for AWS registered installations), or manually with /q review slash command in a comment.

Customization

You can create project-specific rules for Amazon Q Developer to follow:

1. Create a .amazonq/rules folder in your project root.
2. Add Markdown files in this folder to define rules (e.g., cdk-rules.md).
3. Write detailed prompts in these files, such as coding standards or best practices.
4. Amazon Q Developer will automatically use these rules when generating code or providing assistance.

Example rule:

All Amazon S3 buckets must have encryption enabled, enforce SSL, and block public access.
All Amazon DynamoDB Streams tables must have encryption enabled.
All Amazon SNS topics must have encryption enabled and enforce SSL.
All Amazon SNS queues must enforce SSL.

Feedback

To provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository.

For more detailed information, visit the Amazon Q for GitHub documentation.

Footnotes

1. Amazon Q Developer uses generative AI. You may need to verify generated code before using it in your environment. See the AWS Responsible AI Policy. ↩

[amazon-q-developer]

Review Summary

This PR improves the tmux history copy functionality by targeting specific panes instead of capturing from all panes. The implementation correctly handles the case when inside vs outside tmux sessions.

Key improvements:

• Scopes history capture to the active pane when inside tmux
• Falls back to last active pane when outside tmux
• Maintains the same capture options while preventing cross-pane clipboard capture

Issues identified:

• Missing error handling for when no tmux session exists
• No validation that pane detection succeeded before attempting capture

The changes are functionally sound but would benefit from additional error handling to prevent silent failures or confusing error messages.

---

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

[amazon-q-developer]

The fallback case for when not inside tmux may fail if no tmux session exists. The tmux display-message command will error if there's no tmux server running, causing the function to fail silently or with an error message.

Suggested change

	target_pane="$(tmux display-message -p -F '#{pane_id}' -t '{last}')"
	target_pane="$(tmux display-message -p -F '#{pane_id}' -t '{last}' 2>/dev/null)" || { echo "No tmux session found" >&2; return 1; }

[amazon-q-developer]

The function should validate that target_pane is not empty before attempting to capture the pane. If pane detection fails, this will pass an empty string to the -t option, which may cause unexpected behavior.

Suggested change

	tmux capture-pane -p -J -S -999999 -t "${target_pane}" | clipboard_copy
	if [ -z "$target_pane" ]; then
	echo "Failed to determine target pane" >&2
	return 1
	fi
	tmux capture-pane -p -J -S -999999 -t "${target_pane}" | clipboard_copy