feat: add AWS account, network, and logging security checks - #26
Merged
Conversation
Deepen the AWS audit with four new collectors: - account_security: IAM account summary (root MFA, root access keys, resource counts). - security_groups: security-group ingress rules open to 0.0.0.0/0 or ::/0, scanned across all enabled regions (one row per open rule). - cloudtrail: trail logging status, multi-region, log-file validation. - config_recorders: AWS Config recording status per region, flagging gaps. Add an enabled_regions() helper for the region-scoped checks (each region is skipped independently on error). Wire the checks into aws_runner and audit.py, add mocked-boto3 unit tests, and update the README scope/permission notes.
The AWS collectors import botocore directly, and credentials from `aws login` / IAM Identity Center use the AWS Common Runtime (CRT) credential provider, which needs the `crt` extra (awscrt). Without it, any AWS call fails with MissingDependencyException. Declare botocore[crt] and document the requirement.
ccleberg
force-pushed
the
feat/aws-security-checks
branch
from
July 29, 2026 17:25
2eea4dd to
1092629
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deepens the AWS audit (4 → 8 checks) with account-, network-, and logging-level security posture. Same pattern as the GitHub deepening; no new dependencies.
account_securitysecurity_groups0.0.0.0/0/::/0, across all regions (one row per open rule)cloudtrailconfig_recordersapi.enabled_regions()helper for the region-scoped checks; each region is skipped independently on error so one bad region doesn't abort the check.security_groupsandconfig_recordersare findings-oriented — they only surface open rules / recording gaps.Wired
aws_runner.CHECKS(now 8; 7 on by default, SSO still off) andapplications/aws/audit.py, so both the TUI and the standalone CLI pick them up.SecurityAuditmanaged policy covers the read permissions).Testing
pytest— 50 passing (added 6 mocked-boto3 unit tests for the new collectors: root-MFA parsing, CloudTrail status, Config recording + gap reporting, and the open-vs-scoped security-group logic).ruffclean;audit.pyruns standalone.Note
security_groups,config_recorders) hit every enabled region, so they're slower on multi-region accounts — documented, and deselectable in the TUI. Couldn't run against a live account from here, so a real run is worth it to confirm field mappings (esp. the CloudTrail/Config shapes).