Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add EIP-7702 - new type transaction #960

Open
wants to merge 15 commits into
base: feat/prague-hard-fork
Choose a base branch
from

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented Sep 26, 2024

Description

➡️ Added EIP-7702 - new type transaction for Prague hard fork
➡️ Changed basic EVM transact functions call

⚠️ Special attention: it brings breaking changes, as a new version of aurora-evm transact functions has breaking changes, wich includes new fields related to EIP-7702.

Gas cost

➡️ Gas costs decreased. In some cases significantly.

@mrLSD mrLSD self-assigned this Sep 26, 2024
@mrLSD mrLSD added C-enhancement Category: New feature or request S-do-not-merge Status: Do not merge A-testing Area: If something has added tests, or changed them. A-evm-compatibility Area: EVM compatibility changes or fixes. A-engine Area: purely engine EVM related labels Sep 26, 2024
@aleksuss
Copy link
Member

aleksuss commented Oct 7, 2024

It would be good to add some integration tests/examples which demonstrate the new functionality.

engine-transactions/src/eip_7702.rs Outdated Show resolved Hide resolved
engine-transactions/src/eip_7702.rs Outdated Show resolved Hide resolved
engine-transactions/src/eip_7702.rs Outdated Show resolved Hide resolved
@mrLSD mrLSD requested a review from birchmd October 8, 2024 11:12
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me now, nice work. I still think it would be nice to have some integration tests for this feature. I think the following tests would be good to have:

  • Happy path: EOA delegates code to a contract and then a transaction to that EOA executes successfully
  • Error path: Delegation fails for incorrect nonce
  • Error path: Delegation fails for incorrect chain id
  • Error path: Delegation fails for invalid signature

engine-transactions/src/eip_7702.rs Show resolved Hide resolved
engine-tests/src/tests/repro.rs Outdated Show resolved Hide resolved
@mrLSD mrLSD removed the S-do-not-merge Status: Do not merge label Jan 14, 2025
@mrLSD mrLSD changed the base branch from develop to feat/prague-hard-fork January 16, 2025 15:58
@mrLSD
Copy link
Member Author

mrLSD commented Jan 16, 2025

@birchmd @aleksuss for this PR was:
➡️ Changed EVM config to: Prague. In other way it's impossible to pass integration tests
➡️ For now PR related with #988 - Prague hard fork for Engine
➡️ Added unit tests for EIP-7702: nonce, signature
➡️ Added integration tests for EIP-7702. It's a bit tricky, as we can'y directly detect in integrations tests, that auth_list is wrong. So I invented some smartcontract code to simulate that situation and cover some wrong executions. It simulates new types of transactions and some interesting aspects. Keep in mind, that the most important EVM tests inside SputnikVM itself. For Engine most important to validate new transactions itself and creating auth_list. It was covered for 💯 .
➡️ As you can see in #988 - gas consumption was changed. Changes was merged from #988

@mrLSD mrLSD requested a review from birchmd January 16, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-engine Area: purely engine EVM related A-evm-compatibility Area: EVM compatibility changes or fixes. A-testing Area: If something has added tests, or changed them. C-enhancement Category: New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants