UPSTREAM PR #19633: fix modernBERT conversion to GGUF#1179
Open
UPSTREAM PR #19633: fix modernBERT conversion to GGUF#1179
Conversation
|
The analysis encountered an error. Please review the Processing Details for more information. |
1 similar comment
|
The analysis encountered an error. Please review the Processing Details for more information. |
823244c to
bab7d39
Compare
|
No meaningful performance changes were detected across 115492 analyzed functions in the following binaries: build.bin.llama-cvector-generator, build.bin.libllama.so, build.bin.libmtmd.so, build.bin.llama-tts, build.bin.libggml-cpu.so, build.bin.libggml-base.so, build.bin.libggml.so, build.bin.llama-bench, build.bin.llama-tokenize, build.bin.llama-quantize, build.bin.llama-qwen2vl-cli, build.bin.llama-gemma3-cli, build.bin.llama-gguf-split, build.bin.llama-llava-cli, build.bin.llama-minicpmv-cli. 🔎 Full breakdown: Loci Inspector. |
a92fe2a to
6495042
Compare
9f4f332 to
4298c74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: ggml-org/llama.cpp#19633
Fixed bug that was causing conversion to fail:
python convert_hf_to_gguf.py ModernBERT-base --outfile modernbert-base-f16.gguf --outtype f16Basically we have to ignore the head decoder norm from
answerdotai/ModernBERT-base