UPSTREAM PR #19669: test(server): add multi-image and no-image vision API tests#1186
Open
UPSTREAM PR #19669: test(server): add multi-image and no-image vision API tests#1186
Conversation
Add three new test cases to test_vision_api.py that address the TODO for testing with multiple images and no images: - test_vision_chat_completion_multiple_images: verifies the server handles multiple image_url content parts in a single request - test_vision_chat_completion_no_image: verifies text-only messages work correctly on a multimodal model - test_vision_chat_completion_no_image_content_parts: verifies content parts with only text type (no image_url) work correctly The audio test TODO is narrowed to note it needs a model with audio input support, which the current tinygemma3 test model lacks. Co-authored-by: Cursor <cursoragent@cursor.com>
loci-dev
temporarily deployed
to
PROD__AL_DEMO
GitHub Actions
Inactive
|
No meaningful performance changes were detected across 115587 analyzed functions in the following binaries: build.bin.llama-tts, build.bin.libmtmd.so, build.bin.llama-cvector-generator, build.bin.libllama.so, build.bin.llama-bench, build.bin.llama-gemma3-cli, build.bin.llama-gguf-split, build.bin.llama-llava-cli, build.bin.llama-minicpmv-cli, build.bin.llama-quantize, build.bin.libggml-cpu.so, build.bin.libggml-base.so, build.bin.libggml.so, build.bin.llama-tokenize, build.bin.llama-qwen2vl-cli. 🔎 Full breakdown: Loci Inspector. |
loci-dev
force-pushed
the
main
branch
6 times, most recently
from
a6ecec6 to
9ea4a65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: ggml-org/llama.cpp#19669
Summary
test_vision_api.pyaddressing the TODO at line 73 for testing with multiple images and no imagestinygemma3lacks)New Tests
test_vision_chat_completion_multiple_imagesimage_urlcontent parts in a single requesttest_vision_chat_completion_no_imagetest_vision_chat_completion_no_image_content_partstexttype (noimage_url) works correctlyTest plan
tinygemma3preset; multi-image test usesn_ctx=2048to fit both images