UPSTREAM PR #17468: Add OSC 133 P (k=) markers for semantic prompts#35
Open
UPSTREAM PR #17468: Add OSC 133 P (k=) markers for semantic prompts#35
Conversation
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
loci-dev
force-pushed
the
main
branch
4 times, most recently
from
9959a09 to
e8b3494
Compare
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
loci-dev
force-pushed
the
main
branch
3 times, most recently
from
5ba262f to
93a7da4
Compare
- Add SemanticPromptMode enum for better encapsulation - Refactor prompt rendering to use helper methods, eliminating duplication - Add wrap_prompt_indicator to try and get it sending the right escapes
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
…ved clarity and consistency
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
loci-dev
force-pushed
the
main
branch
6 times, most recently
from
d9bae9e to
068b2bc
Compare
loci-dev
force-pushed
the
main
branch
6 times, most recently
from
da22582 to
3f38f88
Compare
loci-dev
force-pushed
the
main
branch
7 times, most recently
from
64bcc48 to
d0a8c7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: nushell/nushell#17468
Description
This PR adds OSC 133;P prompt kind markers (
k=i,k=s,k=r) to properly distinguish between different prompt types in semantic shell integration.Release notes summary - What our users need to know
Terminal emulators with semantic prompt support (like Ghostty) can now properly distinguish between primary prompts, right prompts, and continuation prompts. This improves prompt navigation and other shell integration features.
Tasks after submitting