UPSTREAM PR #17480: Fix verbose flag output for mkdir and mv commands#42
Open
UPSTREAM PR #17480: Fix verbose flag output for mkdir and mv commands#42
Conversation
Fixes issue #16926 where verbose flags had confusing output: - mkdir -v showed only directory name instead of full creation message - mv -v showed 'mv-verbose-renamed' instead of meaningful output Changes: - mkdir -v now shows 'created directory <path>' for single directories - mkdir -v now shows 'created directories: <paths>' for multiple directories - mv -v now shows 'moved <source> -> <target>' for single file moves - mv -v now shows 'moved N files to <target>' for multiple file moves - Disabled verbose output from underlying uutils libraries to avoid duplication - Provided clear, consistent verbose messages that match user expectations The verbose output is now informative and follows standard Unix conventions.
64bcc48 to
d0a8c7a
Compare
6102c29 to
d8ed90c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: nushell/nushell#17480
Description
Fixes #16926
The verbose flags (
-v) formkdirandmvcommands produced confusing output:mkdir -vshowed only the directory name instead of a creation messagemv -vshowed crypticmv-verbose-renamedinstead of meaningful outputChanges
mkdir -v
created directory <path>created directories: <path1>, <path2>, ...mv -v
moved <source> -> <target>moved N files to <target>Also disabled verbose output from underlying uutils libraries to avoid duplication.
Before
After
User-Facing Changes
Verbose output for
mkdirandmvnow shows clear, informative messages that follow standard Unix conventions.Tests + Formatting
cargo fmtandcargo clippy