UPSTREAM PR #17479: Fix DTD error message to suggest correct syntax#43
Open
UPSTREAM PR #17479: Fix DTD error message to suggest correct syntax#43
Conversation
Fixes issue #17145 where the error message for XML files with DTDs suggested using --allow-dtd flag on the open command, but this flag only exists on the 'from xml' command. The fix detects DTD-related XML parsing errors and provides the correct suggestion: 'open --raw file.xml | from xml --allow-dtd' Changes: - Modified open command error handling to detect DTD errors - Updated help message to suggest the correct command syntax - Added test to verify the fix works correctly
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
loci-dev
force-pushed
the
main
branch
7 times, most recently
from
64bcc48 to
d0a8c7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: nushell/nushell#17479
Description
Fixes #17145
When opening an XML file with a DTD declaration, the error message previously suggested using
--allow-dtdflag on theopencommand. However, this flag only exists on thefrom xmlcommand.Changes
opencommand error handling to detect DTD-related XML parsing errorsopen --raw 'file.xml' | from xml --allow-dtdBefore
After
User-Facing Changes
Error messages for XML files with DTDs now provide correct instructions on how to parse them.
Tests + Formatting
cargo fmtandcargo clippy