UPSTREAM PR #17589: use RFC 3339 formatting for displaying dates with year > 9999#59
Open
UPSTREAM PR #17589: use RFC 3339 formatting for displaying dates with year > 9999#59
Conversation
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: nushell/nushell#17589
Fixes #17588
All existing tests should still be passing.
Previously,
format datewould silently switch to using RFC 3339 format for dates before the year 0, and would panic for dates after the year 9999. This PR changes that behavior, andformat datenow errors for dates outside the 0-9999 range by default and suggests using RFC 3339 format.Release notes summary - What our users need to know
Fixed panic for displaying date values after the year 9999
More informative error for
format datewith dates outside the 0-9999 year rangeTasks after submitting